xgiovio/dvdisaster
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: configure: add DEBUG_PRINTF_FORMAT=1 to catch printf format eerrors

Browse Source
This commit is contained in:
Stéphane Lesimple
2021-01-15 19:19:02 +01:00
parent 83acea4684
commit a3aedbd4a2
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
configure vendored
View File

@@ -5,13 +5,25 @@
BASH_BASED_CONFIGURE=./scripts/bash-based-configure BASH_BASED_CONFIGURE=./scripts/bash-based-configure
BASH_BASED_CONFIGURE_OPTS="--buildtmp=$(pwd)/build $@" BASH_BASED_CONFIGURE_OPTS="--buildtmp=$(pwd)/build $@"
REQUIRED_CFLAGS="-DPATCHLEVEL=5 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I. -pipe" REQUIRED_CFLAGS="-DPATCHLEVEL=5 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I. -pipe"
RECOMMENDED_CFLAGS="-O2 -fomit-frame-pointer -Wall -Wno-deprecated-declarations -Wno-stringop-truncation" RECOMMENDED_CFLAGS="-O2 -fomit-frame-pointer -Wall -Wno-unknown-warning-option -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-format-zero-length"
DEBUG_CFLAGS="-ggdb -Wall" DEBUG_CFLAGS="-ggdb -Wall"
if [ "$CLI_ONLY" = 1 ]; then if [ "$CLI_ONLY" = 1 ]; then
REQUIRED_CFLAGS="-DCLI $REQUIRED_CFLAGS" REQUIRED_CFLAGS="-DCLI $REQUIRED_CFLAGS"
fi fi
if [ "$DEBUG_PRINTF_FORMAT" = 1 ]; then
# don't use the binary compiled with this,
# it's only useful to properly get all the build-time
# warnings around printf-errors, that are otherwise
# not catched by the compiler because of the _() macro
REQUIRED_CFLAGS="-DDEBUG_PRINTF_FORMAT $REQUIRED_CFLAGS"
else
# warnings given by -Wformat-security are bogus
# because of _(), see above comment.
RECOMMENDED_CFLAGS="$RECOMMENDED_CFLAGS -Wno-format-security"
fi
CFG_USE_CYGWIN="no" # do not change CFG_USE_CYGWIN="no" # do not change
if test -e $BASH_BASED_CONFIGURE; then if test -e $BASH_BASED_CONFIGURE; then

6
src/dvdisaster.h
View File

@@ -72,8 +72,14 @@
Note that these functions are even required when Note that these functions are even required when
WITH_NLS_NO is set! */ WITH_NLS_NO is set! */
#ifdef DEBUG_PRINTF_FORMAT
/* disable sgettext() calls so that the compiler can analyze printf format strings */
#define _(string) string
#define _utf(string) string
#else
#define _(string) sgettext(string) #define _(string) sgettext(string)
#define _utf(string) sgettext_utf8(string) #define _utf(string) sgettext_utf8(string)
#endif
/* File permissions for images */ /* File permissions for images */